Add RAK12035VB Soil Moisture Sensor support #5481
Open
+488
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…/firmware into AddRAK12035_attempt2
…or expected values..
…/firmware into AddRAK12035_attempt2
… some of the rak4631 variants
|
Thanks for the updates and welcome to Meshtastic :) As you've probably seen, the protobufs don't like to be checked in -- they're automatically generated, so its best to remove them from this commit. If you need help working with the git submodules let us know, they're a bit tricky :) |
…ch form my project since there has not been that much guidance in terms of next steps for this branch.
…ties are already being used or 'set'. if not use them for the soil monitor.
|
@Justin-Mann i'd really like to include this, but due to heavy lifting in the sensor code and a few unfortunate checkins this PR is now conflicted beyond repair. Do you object if i sent in a new cleaned up PR and credited you as the author? |
|
@caveman99 feel free. I just havn't really dealt with the tests on the other software
platforms failing and have not had a ton of time to look into it more.. was
actually just thinking about restructuring a little bit and trying again in
the near future.. but if you feel like writing it correctly.. on the newest
branch.. feel free man. I'm probably online all day today if I can help in
any way.
Thanks,
Justin
#mcluvin7930
... EDIT: If you end up implementing this in the firmware let me know.. I'll start working on clients to get ne logistics parameters in... *** also.. I am not sure if my shenanigans made it into the remote branch (probably as another user was interested in them), but I am miss-using the environmental logistics parameters 'variant.environment_metrics.temperature' and 'variant.environment_metrics.relative_humidity' in RAK12035VBSensor::getMetrics. I should not be overwriting in this way and will happily follow up with modifications to the 3 client repos. basically I'll just add 'variant.environment_metrics.soil_temperature' and 'variant.environment_metrics.soil_moisture' to the applicable models unless you have other thoughts..
…On Sun, Jan 5, 2025 at 3:50 AM Thomas Göttgens ***@***.***> wrote:
@Justin-Mann <https://github.com/Justin-Mann> i'd really like to include
this, but due to heavy lifting in the sensor code and a few unfortunate
checkins this PR is now conflicted beyond repair. Do you object if i sent
in a new cleaned up PR and credited you as the author?
—
Reply to this email directly, view it on GitHub
<#5481 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAFYBVH2SMHI4ZSU7CLZPT2JEE67AVCNFSM6AAAAABSXVLPSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGU4DGMBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the RAK12035VB sensor as an environmental telemetry sensor, including necessary calibration checks and default values. Update relevant files to integrate the sensor into the existing telemetry system.
I did as good a job as I could up to this point, but some correction may be necessary..
I kinda had an idea of how I wanted things to go, and I think the basic detection and registration methods being used for the sensors are probably enough so I did not implement any guards specific to the RAK soil monitoring.
This hardware is not just one module, but a couple.. RAK12023 and RAK12035 is the component stack, the RAK12023 does not seem to matter much and allows for multiple RAK12035 devices to be used. *I did not code support for multiple RAK12035, but this could be handled in code if desired... *I wrote very simple support to default the configuration values for the soil moisture levels.. this could be imporved, but is a complex interaction so I would suggest doing what I did until the mobile apps are enhanced to support the new environmental data points.. (perhaps something could be built into the mobile admin gui to perform a water monitor config routine with feedback).
The main issue I have atm..
in ScanI2CTwoWire.cpp ln. 347...
I defined a case for devices with address 0x20.. I don't know where I got the values I did (probably left over from the pervious night's coding session from a copy and paste), but they do not work.. that check does not work.. I tried to run down registry uuid locations for both devices, but came up short.. and.. I'm apparently bad at this, so if anyone has more refined detection methods I could use or knowledge around this any help would be appreciated.