First attempt to adding hardware support for NRF52 SPI SD Card #5561
Conversation
…arduino SD library My first time contributing to an open source project so not very confident in what i'm doing. Changes to FSCommon: initializing SD library for NRF52. Progress: No compile error, but SD card does not get initialized properly yet added ifdef ARCH_ESP32 conditions around esp32 SD library functions memget: added ifdef conditional statements StoreForwardModule.cpp: added ifdef conditional statements Rak4631 platfromIO.ini and variant.h: added arduino-libraries/SD@^1.3.0 library to libdeps defined HAS_SDCARD and SPI pins Arduino SD library. Made changes to library because using namespace SDLIB in header file caused ambiguity problems Not sure this is the right way of adding a library, also, how do i implement changes to the library permanently to the project? Am I going somewhat in the right direction with these changes? Tell me your thoughts, thanks
A "using namespace" statement in the header file was to messy to work around. NRF52 SD card initialisation added
|
There is already an open draft pull from one of our primary firmware developers for this |
How can I add/propose my commits to this draft pull request? |
added card size and type function to SD library added populateSDCard for NRF52
Changed NRF52 SD object from SDFilesystem to SD for more compatibility with esp32 SD library. Some functions are still different but most used open, read, write and close are the same.
There was a problem hiding this comment.
There is a lot of duplicate code in there. what about instead defining a couple of wrapper functions to emulate the original ESP32 sdcard driver? Also the test file on init is not neccessary. Ihe way it is not it makes the code really problematic to maintain.
Mainly made changes to the custom arduino SD library to make it compatible with the esp32 SD library already used in the store and forward code. With these compatible function names and return, I removed some duplicate code.
|
Made changes to the SD library and removed (most) duplicate code. Checking how much space is already used is not implemented in the arduino SD library. The SD.begin() function for esp32 gives the spi interface object as an argument. The arduino library uses a "#define SDCARD_SPI" statement to tell the underlying sd2fat library what spi interface to use. So now the SD.begin() function takes an SPI interface argument but does not use it. Not sure how this should be solved in a clean way. |
My first time contributing to an open source project so not very confident in what i'm doing.
Changes to
FSCommon:
initializing SD library for NRF52. Progress: No compile error, but SD card does not get initialized properly yet added ifdef ARCH_ESP32 conditions around esp32 SD library functions
memget: added ifdef conditional statements
StoreForwardModule.cpp: added ifdef conditional statements
Rak4631 platfromIO.ini and variant.h:
added arduino-libraries/SD@^1.3.0 library to libdeps defined HAS_SDCARD and SPI pins
Arduino SD library. Made changes to library because using namespace SDLIB in header file caused ambiguity problems Not sure this is the right way of adding a library, also, how do i implement changes to the library permanently to the project?
Am I going somewhat in the right direction with these changes? Tell me your thoughts, thanks