Add ADS1X15 voltage metrics #711
Draft
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caveman99 - I am not able to allow you for editing the PR because of this: https://github.com/orgs/community/discussions/5634 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADS1X15 ADCs are 4-channel I2C ADCs with configurable I2C Addresses. This PR adds the SensorType and created an additional channel for it in the PowerMetrics` protobuf.
What does this PR do?
This PR adds the
TelemetrySensorTypeand creates an additional channel for it in thePowerMetricsprotobuf.This, is however incomplete: the problem being that up to 4x ADS1X15s can be chained together, and each one of them with 4 channels, making up for a total of 16 channels.
Checklist before merging