Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA offline support for standalone web app install #194

Closed
wants to merge 1 commit into from

Conversation

stevenpovlitz
Copy link

Addresses #182

This is my first PR to meshtastic and meshtastic/web, please point out contribution policies and conventions. The code is pulled from the default service worker setup from running:

npx create-react-app my-app --template cra-template-pwa-typescript

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Hunter275 Hunter275 added enhancement New feature or request minor change This is a minor change labels Jun 16, 2024
@dzienisz
Copy link
Contributor

I like this idea of making this app installable.

Copy link
Collaborator

@danditomaso danditomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like its missing workbox-core being added to the package.json. As well it looks like it uses functions from workbox-core v3 instead of using the latest v4 version, functions such as clientsClaim doesn't exist in v4.

@KomelT
Copy link
Member

KomelT commented Feb 27, 2025

Closing this PR because this work was already merged in #468

@KomelT KomelT closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor change This is a minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants