Add PKI backup dialog, add reminder toast to suggest backing up private key. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort regenerate dialog
|
@Hunter275 Here is the PR I was mentioning |
danditomaso
changed the title
danditomaso
force-pushed
the
add_pki_backup_dialog
branch
from
5a9b940 to
c93cdbc
Compare
danditomaso
changed the title
danditomaso
force-pushed
the
add_pki_backup_dialog
branch
from
c93cdbc to
7cd03c6
Compare
Added empty value to pre-shared key size. Feature parity with IOS app
…ort regenerate dialog
…o/meshtastic-web into add_pki_backup_dialog
|
I think we need to length the amount of time the Toast message appears on screen or it needs to stay on screen until closed or acted upon. |
|
Sounds good, I was also thinking, does this feature really fully cover what needs to be backed up? Because backing up the private key without backing up the public key is kind of useless. They are a key pair and I believe they need to be backed up together? What are your thoughts? |
…ed duration/delay to control length of toast.
|
|
Sounds good, I'll make the changes and tag you when they're ready for review again. Thanks for the feedback. |
Hunter275
added
enhancement
|
Sorry had forgot to push the latest commit, fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PKI Backup dialog which provides the ability for the user to download their private key in a text file, or print a copy of their key.
The backup dialog can be used at any time from the Security tab, which makes sense given that a user may regenerate their key.
This includes adding a toast style reminder to backup their private key, once they go through the backup dialog it sets a cookie which will be read to avoid creating the showing the toast next time. They can also dismiss this dialog which also sets the cookie, I dont believe this change will be that intrusive as it uses a toast to remind the user.
I found the toast component didn't appear correctly for any use besides a simple toast with a title, so I made some changes to it to better support dark mode and improve the DX; these changes kept the API of the toast component the same and are most focused on the styling.
Let me know if there are any changes/fixes you'd like me to make.
Fixes #281