Fix NodeInfoDialog initiation

[philon-]

Description

This PR fixes an issue that was introduced in #618 where NodeInfoDialog was not opened using DialogManager

Related Issues

Changes Made

• Write node.num to appStore instead of passing it to the component
• Change onClick callback
• Update tests

Testing Done

Screenshots (if applicable)

Checklist

• Code follows project style guidelines
• Tests have been added or updated
• All CI checks pass

Additional Notes

[vercel]

@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

[Copilot]

Pull Request Overview

This PR refactors how the NodeInfoDialog is opened by moving the node number into the app store and using DialogManager instead of passing props, and updates the related dialog component and its tests.

• Triggering the node details dialog now writes node.num to appStore and calls setDialogOpen instead of using component state
• NodeDetailsDialog is updated to retrieve its node from useDevice().getNode(nodeNumDetails) and no longer takes a node prop
• Tests for NodeDetailsDialog are revised to mock the new hook-based data flow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/pages/Nodes.tsx	Refactored node detail dialog trigger to use setNodeNumDetails and setDialogOpen
src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.tsx	Converted dialog component to fetch its node via store hooks instead of props
src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.test.tsx	Updated mocks and test cases to reflect the new hook-based data retrieval

Comments suppressed due to low confidence (2)

src/pages/Nodes.tsx:33

• The hasNodeError variable is no longer used in this component after the refactor. Consider removing it to avoid unused destructuring.

const { getNodes, hardware, connection, hasNodeError, setDialogOpen } = useDevice();

src/components/Dialog/NodeDetailsDialog/NodeDetailsDialog.test.tsx:55

• Add interaction tests for the dialog action buttons (favorite toggle, ignore toggle, request position, traceroute, remove node) to verify that each handler is wired up correctly.

it("renders node details correctly", () => {

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-test	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2025 11:12pm