Persistent connection dialog #708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove deprecated meshtastic/js dependency * Bump dependency version * Fix linting --------- Co-authored-by: philon- <[email protected]>
servers and i18n support - Move connection tabs from Dialog to PageComponents/Connect/Tabs for better organization - Add persistent HTTP server storage with status tracking in appStore - Implement hostname parsing and validation utilities - Default new HTTP connections to HTTPS for better security - Add comprehensive i18n translation support for all connection tab strings - Remove package-lock.json in favor of deno.lock dependency management - Update connection tab UI with improved server management (add/edit/remove) - Remove preliminary status checking logic (to be reimplemented with toradio API) - Maintain fixed window constraints for large monitor compatibility
- Remove automatic server status checking from HTTP components - Eliminate status tracking overhead in HTTPServerSection and HTTP tab - Simplify persistent server list by removing status indicators - Clean up unused imports and status-related functions - Replace || with ?? for nullish coalescing consistency
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR brings the persistent connection dialog feature up to date with main, introducing a unified tabbed UI and server history persistence.
- Dashboard now uses
NewConnectionDialogwith HTTP/Bluetooth/Serial tabs and conditionally inlines tabs when no devices exist. - Added hostname parsing and formatting utilities (
parseHostname,formatHostnameForConnection, etc.). - Extended
appStoreto tracksavedServerswith add/remove/update operations and localStorage persistence. - Minor UI refinements in tabs and connection components across Serial, HTTP, and Bluetooth integrations.
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/pages/Dashboard/index.tsx | Replaced old connect dialog with NewConnectionDialog, added inline ConnectionTabs and conditional rendering. |
| packages/web/src/core/utils/hostname.ts | Introduced parseHostname, validation helpers, and formatting functions. |
| packages/web/src/core/stores/appStore.ts | Added savedServers state, CRUD methods, and localStorage syncing. |
| packages/web/src/core/hooks/useLocalStorage.ts | Adjusted effect dependency arrays in useLocalStorage hook. |
| packages/web/src/components/UI/Tabs.tsx | Enhanced active state styling in TabsTrigger. |
| packages/web/src/components/Dialog/NewConnectionDialog.tsx | New wrapper dialog for connection tabs. |
| packages/web/src/components/ConnectionTabs/ConnectionTabs.tsx | Layout component for HTTP/Bluetooth/Serial tab selection. |
| packages/web/src/components/PageComponents/Connect /* | Added new HTTP, Bluetooth, and Serial tab implementations under Connect/Tabs. |
| packages/web/src/App.tsx | Redirect to messages on device connect and updated routing logic. |
Comments suppressed due to low confidence (1)
packages/web/src/pages/Dashboard/index.tsx:99
- The
Headingcomponent is used here but not imported at the top of the file. Please add the appropriate import, for example:
import { Heading } from "@components/UI/Typography/Heading.tsx";
<Heading as="h3">
packages/web/src/components/PageComponents/Connect/Tabs/SerialTab.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…Tab.tsx Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is code that was taken from #645, @tpaulsoncdw is the only author of this PR. This PR brings his changes up to date with main. Below was taken from his PR. He deserves to be recognised for this wonderful contribution that wasn't merged at the time.
--- Original PR below
Looking to help how I can and this is an area that has impacted me so i though maybe i could help with this. it needs some more polish and testing but its not far off.
Description
Adds persistent HTTP node connections with optional HTTPS toggle, enabling simply reconnection across page refresh or tab reload.
Introduces a unified tabbed UI for connecting via HTTP, Bluetooth, or Serial, reducing friction for new users and testing workflows.
Related Issues
Relates to #345
Fixes #241
Fixes #164
Fixes #701
Changes Made
HTTP,Bluetooth,Serial)Testing Done
Verified HTTP(S) node addition with:
Let's Encrypt–signed certs
Self-signed certs (via NGINX + local DNS)
Confirmed nodes persist after refresh and page reloads
Tested multi-node handling with different protocols
Observed successful connection status returns in some cases
Initial test results are promising, but status polling is incomplete
Unencrypted HTTP (non-TLS) needs final testing and browser validation
Screenshots (if applicable)
Connect Modal:
Checklist
Future Enhancements