Compatibility for Mac OS X #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't notice this pull-req before, sorry. Is the issue already fixed in master? Or do you mind updating it to the existing code? Thanks for submitting it. |
|
Hi, @meskio. No problem. I've solved the code conflict. The Pull Request is updated. |
|
I think you mixed a bit your git. If I understand correctly you rebased the origin's master into your branch, so you modify my commits to fit on top of yours. Can you do it the other way around? rebasing your commits on top of the git master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables Tudu to be compiled in MAC OS X.
It solves the error message: