Select static from both_libraries in internal dep #12110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
dep-as-static
branch
from
105d471 to
61b050f
Compare
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
bruchar1
force-pushed
the
dep-as-static
branch
from
61b050f to
5a153f1
Compare
bruchar1
changed the title
|
Regarding the FIXME comment in the test, I think I will be able to address it once #11981 is merged. |
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
bruchar1
force-pushed
the
dep-as-static
branch
from
5a153f1 to
815e63c
Compare
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
xclaesse
reviewed
Aug 11, 2023
bruchar1
force-pushed
the
dep-as-static
branch
from
815e63c to
1ea5e1a
Compare
Add `.as_static()` method to internal dependencies. Internal dependencies can now choose between static and shared version of a `both_libraries` linked library. This allows to use the same dependency objects for building either a static or a shared library from the same hierarchy of dependencies.
bruchar1
force-pushed
the
dep-as-static
branch
from
1ea5e1a to
a9d660d
Compare
|
Closed in favor of #12632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.as_static()method to internal dependencies.Internal dependencies can now choose between static and shared version
of a
both_librarieslinked library. This allows to use the samedependency objects for building either a static or a shared library from
the same hierarchy of dependencies.