Meson format #12318
Meson format #12318
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bruchar1
force-pushed
the
meson-format
branch
6 times, most recently
from
7972813 to
0df9d99
Compare
|
cc @JCWasmx86 |
|
Thanks for pinging me tristan957, I closed #10971 |
bruchar1
force-pushed
the
meson-format
branch
from
0302286 to
afaf13a
Compare
|
rebased, and targeted for 1.4.0 |
There was a problem hiding this comment.
A few of these commits could use more detailed commit messages.
The first one I suspect (though I haven't checked) was originally only for keyword arguments so column made sense, and stopped making sense as we extended it to additional places.
Overall I like this a lot, and while there's some additional things I'd like to handle here, I think those are fine follow ons.
I t would be nice if meson format would automatically load a meson.format file that was at the root of the source directory so that proejcts could just run meson format and not have to worry about passing in the format rules if they're defined globally
- Wrong types were used for MultilineStringNode and FormatMultilineStringNode - Simplify the `escape` method to avoid use of T.Cast
In #02ff955, I used the word `columns` instead of `colons`, but the meaning really was about the ':' symbol.
The `AstVisitor` intentionally ignores whitespaces and symbols, as they are not useful for tne interpreter. However, when formatting a build file, we need them. This commit introduces a `FullAstVisitor` that visits every Nodes, including whitespaces and symbols.
Use the new `FullAstVisitor` for `AstConditionLevel`. This will allow proper formatting of `if / else / endif` and `foreach / endforeach` blocks.
this will allow transforming string types in the formater
I tried to improve it. But I am open to suggestions...
Done. Will also automatically analyse meson.build in current directory if it is present and no other build files are specified on the command line. |
This is a native
meson formatcommand, similar tomuon fmt.