Update options on reconfigure when default_options changes #12319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclaesse
force-pushed
the
option-source2
branch
4 times, most recently
from
0841f9c to
63d97a3
Compare
It uses typed_kwargs() already in that case.
Allow convertor function to raise MesonException to validate and convert in a single step. This avoids splitting "foo=bar" twice.
xclaesse
force-pushed
the
option-source2
branch
from
63d97a3 to
6166006
Compare
This requires storing the option value and only allow updating if the new value comes from a higher priority source.
When using a fallback for `dependency('foo', required: false)` and the
user has set some options on the subproject via a machine file or
`-Dfoo:opt=value`, consider the user wanted to use that subproject and
make the error fatal.
xclaesse
force-pushed
the
option-source2
branch
from
6166006 to
18ce1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of the source of each option value and only override a value with one from same or higher priority source.
This also allows fixing an inconvenient user experience in GStreamer:
gst-plugins-badsubproject is optional but if user enables one of its plugins with-Dgst-plugins-bad:aom=enabledwe should fail even if user forgot to pass-Dbad=enabledoption to makegst-plugins-badsubproject required.