CI misc updates #12325
Merged
CI misc updates #12325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They do not appear to have 20 in their repos anymore, and no traces can be found of it in the history, as usual. They do have 11, 17, and 21. Last time we chose one randomly and hoped it doesn't keep changing value. This dismally failed: 20 was upgraded to 21. It looks like 17 may have some staying power.
Regression in commit 0af126f. We added support for some "test cases/" stuff that actually relies on test files being a symlink, but when testing the image builder, we copied the meson repository contents into the docker container without telling python that it is in fact super important to copy symlinks as symlinks. As a result, the tests themselves ran fine when merging, but caused the image builder to thereafter fail.
In commit 5c479d7, we deleted bad stuff that makes python not work. But we missed the case where it is installed to lib64.
eli-schwartz
commented
Oct 4, 2023
| @@ -143,13 +143,14 @@ def copy_meson(self) -> None: | |||
| shutil.copytree( | |||
| self.meson_root, | |||
| self.temp_dir / 'meson', | |||
| symlinks=True, | |||
There was a problem hiding this comment.
@ArsenArsen your #10594 triggered this bug. :P
There was a problem hiding this comment.
I see that as my change preventing it from manifesting later :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eternal quest to get CI images periodically updating. This doesn't actually fix anything, but it does make the image builders get a bit further before erroring: in particular, the opensuse image now successfully builds, so we can see where the self-tests fail.