Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: proc-macro should be ignored in transitive dependencies #12460

Merged
merged 1 commit into from
Nov 2, 2023
Merged

rust: proc-macro should be ignored in transitive dependencies #12460

merged 1 commit into from
Nov 2, 2023

Conversation

xclaesse
Copy link
Member

@xclaesse xclaesse commented Nov 2, 2023

Fixes: #12459

@xclaesse xclaesse requested a review from jpakkane as a code owner November 2, 2023 15:37
@xclaesse xclaesse mentioned this pull request Nov 2, 2023
Closed
@xclaesse
Copy link
Member Author

xclaesse commented Nov 2, 2023

We don't currently have Rust cross compilation CI so the unit test does not really catch the issue ATM, but I verified manually that libpm.so was passed to footest link command and this PR removed it.

@xclaesse xclaesse changed the title rust: proc-macro transitive dependencies should be ignored rust: proc-macro should be ignored in transitive dependencies Nov 2, 2023
@gfxstrand
Copy link
Contributor

Other than the one comment above, everything looks good to my uneducated (about meson) eye. I've also tested it with my Mesa nak branch and it fixes the bug. 32-bit builds seem to work okay now.

@eli-schwartz
Copy link
Member

I really think we need to add rust cross compilation to the CI if we're going to keep poking at this code. What's the status of doing so??

@dcbaker
Copy link
Member

dcbaker commented Nov 2, 2023

I will have to add it with my series to build subprojects for both machines if not sooner, so... during the next release cycle at the latest?

@xclaesse
Copy link
Member Author

xclaesse commented Nov 2, 2023

What's the status of doing so??

I made a PR to add Windows cross compilation and it exploded in million pieces: #11990. I'll try with Linux aarch64 as an easier first step.

@xclaesse xclaesse merged commit 06b9d1e into mesonbuild:master Nov 2, 2023
56 of 61 checks passed
@xclaesse xclaesse deleted the rust-pm-overlink branch November 2, 2023 18:15
@eli-schwartz
Copy link
Member

I made a PR to add Windows cross compilation and it exploded in million pieces: #11990. I'll try with Linux aarch64 as an easier first step.

The CI image builder now has the aarch64 bits installed in it, and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfxstrand gfxstrand gfxstrand left review comments

@dcbaker dcbaker dcbaker approved these changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
language:rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust: Proc macros end up in library dependencies
4 participants
@xclaesse @gfxstrand @eli-schwartz @dcbaker