Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvcc: avoid adding -Wpedantic to compile lines #12912

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

SoapGentoo
Copy link
Member

  • -Wpedantic creates useless churn due to its use of gcc-line directives: ../foo.cu:1:3: warning: style of line directive is a GCC extension 1 | namespace Foo {
    | ^~
    https://stackoverflow.com/a/31001220

@SoapGentoo SoapGentoo requested a review from dcbaker as a code owner February 27, 2024 10:54
@SoapGentoo SoapGentoo force-pushed the nvcc-filter-Wpedantic branch from 435d365 to d00c76a Compare February 27, 2024 10:57
* `-Wpedantic` creates useless churn due to its use of gcc-line directives:
  ../foo.cu:1:3: warning: style of line directive is a GCC extension
      1 | namespace Foo {
        |   ^~
  https://stackoverflow.com/a/31001220
@SoapGentoo SoapGentoo force-pushed the nvcc-filter-Wpedantic branch from d00c76a to 340c591 Compare February 27, 2024 11:52
@eli-schwartz eli-schwartz merged commit 937d1c6 into mesonbuild:master Feb 29, 2024
35 checks passed
@SoapGentoo SoapGentoo deleted the nvcc-filter-Wpedantic branch February 29, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants