Fix base and compiler options not reconfigurable. #12922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
fix-configure-core-options
branch
6 times, most recently
from
5b44459 to
edc41ba
Compare
dcbaker
reviewed
Mar 1, 2024
This reverts commit 98db3e7.
For instance, on Windows, if the terminal is in cp65001, the subprocess output is not encoded correctly and it results in error when running unit test.
bruchar1
force-pushed
the
fix-configure-core-options
branch
from
edc41ba to
ab331df
Compare
bruchar1
force-pushed
the
fix-configure-core-options
branch
from
ab331df to
f10728b
Compare
bruchar1
force-pushed
the
fix-configure-core-options
branch
from
f10728b to
c2fb47a
Compare
dcbaker
approved these changes
Mar 1, 2024
SoapGentoo
reviewed
Mar 6, 2024
| @@ -974,6 +974,8 @@ def set_options(self, options: T.Dict[OptionKey, T.Any], subproject: str = '', f | |||
| return dirty | |||
|
|
|||
| def set_default_options(self, default_options: T.MutableMapping[OptionKey, str], subproject: str, env: 'Environment') -> None: | |||
| from .compilers import base_options | |||
There was a problem hiding this comment.
@bruchar1 this commit broke subprojects for me:
subprojects/mysubproj/meson.build:1:0: ERROR: In subproject mysubproj: Unknown options: "mysubproj:b_ndebug"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12920.
Note: #12923 is still an issue, i.e. when no languages are setup.