Fix dependencies for vala.links #13158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcorby
force-pushed
the
vala.links-fix
branch
12 times, most recently
from
89087db to
b67e93a
Compare
dcbaker
requested changes
Apr 29, 2024
mesonbuild/compilers/vala.py
Outdated
| if mode is CompileCheckMode.LINK and self.force_link: | ||
| # As we are passing the parameter to valac we don't need the dependent libraries. | ||
| a = d.get_compile_args() | ||
| if len(a) > 0: |
There was a problem hiding this comment.
Suggested change
| if len(a) > 0: | |
| if a: |
There was a problem hiding this comment.
I didn't know you could do this. Thanks.
bcorby
force-pushed
the
vala.links-fix
branch
3 times, most recently
from
d8496bf to
4ad729e
Compare
dcbaker
pushed a commit
that referenced
this pull request
Apr 30, 2024
Using the keyword argument dependencies with compiler.links() for vala doesn't work as the library being linked to needs to be prefixed with --pkg= before being passed to valac.
soumyaDghosh
pushed a commit
to soumyaDghosh/meson
that referenced
this pull request
Jun 4, 2024
Using the keyword argument dependencies with compiler.links() for vala doesn't work as the library being linked to needs to be prefixed with --pkg= before being passed to valac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the keyword argument dependencies with compiler.links() for vala doesn't work as the library being linked to needs to be prefixed with --pkg= before being passed to valac.