Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Builtin-options documentation, clarify warning_level=0 is not 'none' but 'compiler default'. #13188

Merged
merged 1 commit into from
May 9, 2024

Conversation

sammyj85
Copy link
Contributor

@sammyj85 sammyj85 commented May 7, 2024

Addresses side issue (not primary issue) raised in #8636.

@sammyj85 sammyj85 requested a review from jpakkane as a code owner May 7, 2024 02:53
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap the commit message to the standard length? It's 95 characters long which is too long.

@sammyj85 sammyj85 changed the title In Builtin-options documentation, clarify warning_level=0 is not 'none' but 'compiler default'. In Builtin-options documentation, clarify warning_level=0. is not 'none' but 'compiler default'. May 7, 2024
@sammyj85 sammyj85 changed the title In Builtin-options documentation, clarify warning_level=0. is not 'none' but 'compiler default'. In Builtin-options documentation, clarify warning_level=0 is not 'none' but 'compiler default'. May 7, 2024
warning_level=0 is not 'none' but 'compiler default'.
@sammyj85 sammyj85 requested a review from eli-schwartz May 9, 2024 06:11
@eli-schwartz eli-schwartz merged commit f8aefe2 into mesonbuild:master May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants