Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/ninja: fix bad @OUTPUTn@ replacements #13526

Merged
merged 2 commits into from
Oct 12, 2024
Merged

backend/ninja: fix bad @OUTPUTn@ replacements #13526

merged 2 commits into from
Oct 12, 2024

Conversation

chubinou
Copy link
Contributor

@chubinou chubinou commented Aug 7, 2024

outfilelist is the output list of the target, while outfiles is the output list of the individual commands

Bug: /pull/13304#issuecomment-2226398671

@chubinou chubinou requested a review from jpakkane as a code owner August 7, 2024 15:07
@chubinou chubinou mentioned this pull request Aug 7, 2024
Merged
eli-schwartz
eli-schwartz requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a test case for this. As far as I can tell, all the use cases of generator .process() in test cases/ tend to use a single processed file, and the ones that use multiple of them don't use OUTPUTn.

mesonbuild/backend/ninjabackend.py Show resolved Hide resolved
chubinou added 2 commits August 8, 2024 11:55
@chubinou
backend/ninja: fix bad @OUTPUTn@ replacements
b04ac25 
`outfilelist` is the output list of the target, while `outfiles` is the output
list of the individual commands

Bug: mesonbuild/pull/13304#issuecomment-2226398671
@chubinou
test cases: add test for @OUTPUT0@ substitution rules
d94bf57 
when a generator used a single @OUTPUT0@ and was processing multiple targets,
the variable was replaced with a wrong value
@chubinou chubinou force-pushed the outfiles_in_sub_target branch from a8c5f8d to d94bf57 Compare August 8, 2024 10:00
@chubinou
Copy link
Contributor Author

chubinou commented Oct 8, 2024

ping @eli-schwartz @jpakkane

@jpakkane jpakkane added this to the 1.7 milestone Oct 8, 2024
@jpakkane jpakkane merged commit 83d9b21 into mesonbuild:master Oct 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz requested changes

@dcbaker dcbaker dcbaker approved these changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@chubinou @dcbaker @eli-schwartz @jpakkane