ExternalProgram: add cmd_array to complete the offering #13845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrain34
force-pushed
the
dab_full_command
branch
from
a6dbf2e to
9364960
Compare
dabrain34
changed the title
jpakkane
reviewed
Oct 30, 2024
dabrain34
force-pushed
the
dab_full_command
branch
2 times, most recently
from
acbc84e to
2c13517
Compare
dabrain34
changed the title
dabrain34
force-pushed
the
dab_full_command
branch
from
2c13517 to
1eb32c1
Compare
eli-schwartz
requested changes
Oct 31, 2024
xclaesse
reviewed
Nov 1, 2024
| - name: cmd_array | ||
| returns: list[str] | ||
| description: Returns an array containing the command(s) for the program. | ||
| since: 1.6.1 |
There was a problem hiding this comment.
Also need a release snippet, add a file in docs/markdown/snippets/
There was a problem hiding this comment.
Can you give me more details on the expected snippet please ?
|
Should we deprecate full_path() because it's dangerous? At least document that cmd_array() is prefered. |
|
A unit test would be nice too. |
dabrain34
force-pushed
the
dab_full_command
branch
from
1eb32c1 to
20af42f
Compare
|
Added a unit test |
dabrain34
force-pushed
the
dab_full_command
branch
3 times, most recently
from
729b344 to
1cd5775
Compare
dabrain34
force-pushed
the
dab_full_command
branch
from
1cd5775 to
381bd2d
Compare
In case of python and especially in the case of pyInstaller where the python command is meson.exe runpython, it should not be full path to be used but cmd_array. Fixing mesonbuild#13834
dabrain34
force-pushed
the
dab_full_command
branch
from
381bd2d to
f26bb39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of python and especially in the case of pyInstaller where the python command is meson.exe runpython, it should not be full path to be used but cmd_array.
Fixing #13834