New xgettext method to i18n module #13900
Open
+313
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
i18nextract
branch
4 times, most recently
from
9ebc09e to
4f5283b
Compare
This was referenced Nov 14, 2024
Closed
bonzini
suggested changes
Dec 6, 2024
bruchar1
force-pushed
the
i18nextract
branch
2 times, most recently
from
b35d6b7 to
9347ef2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bruchar1
changed the title
dcbaker
requested changes
Dec 10, 2024
|
Since the underlying goal as I understand it is essentially "i18n.gettext() is not suitable for my use case because it depends on POTFILES but I would like to calculate the list from meson.build", it feels a bit like a more appropriate solution here could be to teach |
I understood that he also wants to generate multiple .pot files, so that would not be a single POTFILES. |
bruchar1
force-pushed
the
i18nextract
branch
2 times, most recently
from
0fc8368 to
98a0fd7
Compare
bruchar1
changed the title
bruchar1
force-pushed
the
i18nextract
branch
2 times, most recently
from
cd32835 to
e9596e6
Compare
This method call xgettext to extract translatable string from source files into a .pot translation template. It differs from a plain CustomTarget in three ways: - It accepts build targets as sources, and automatically resolves source files from those build targets; - It detects command lines that are too long, and writes, at config time, the list of source files into a text file to be consumed by the xgettext command; - It detects dependencies between pot extraction targets, based on the dependencies between source targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method call xgettext to extract translatable
string from source files into a .pot translation template.
It differs from a plain CustomTarget in three ways:
files from those build targets;
time, the list of source files into a text file to be consumed by the
xgettext command;
dependencies between source targets.
This does the specific thing I need for my project, that I was trying to implement in a more generic way in #12272 and #11822.