Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci images #13936

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix ci images #13936

merged 2 commits into from
Dec 6, 2024

Conversation

bonzini
Copy link
Collaborator

@bonzini bonzini commented Nov 20, 2024

I have no idea about the Arch failure:

2024-11-20T16:22:36.4765258Z [1/5] c++ -Isubprojects/cmMod/libcmModLib__.so.p -Isubprojects/cmMod '-I../test cases/cmake/1 basic/subprojects/cmMod' -Isubprojects/cmMod/__CMake_build '-I../test cases/cmake/1 basic/subprojects/cmMod/__CMake_build' -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu++14 -O0 -g -fPIC -g -DDO_NOTHING_JUST_A_FLAG=1 -DMESON_MAGIC_FLAG=21 -DcmModLib___EXPORTS -MD -MQ subprojects/cmMod/libcmModLib__.so.p/cmMod.cpp.o -MF subprojects/cmMod/libcmModLib__.so.p/cmMod.cpp.o.d -o subprojects/cmMod/libcmModLib__.so.p/cmMod.cpp.o -c '../test cases/cmake/1 basic/subprojects/cmMod/cmMod.cpp'
2024-11-20T16:22:36.4771685Z [2/5] c++  -o subprojects/cmMod/libcmModLib__.so subprojects/cmMod/libcmModLib__.so.p/cmMod.cpp.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,-soname,libcmModLib__.so -Wl,--dependency-file,CMakeFiles/cmModLib++.dir/link.d
2024-11-20T16:22:36.4773648Z FAILED: subprojects/cmMod/libcmModLib__.so 
2024-11-20T16:22:36.4775912Z c++  -o subprojects/cmMod/libcmModLib__.so subprojects/cmMod/libcmModLib__.so.p/cmMod.cpp.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,-soname,libcmModLib__.so -Wl,--dependency-file,CMakeFiles/cmModLib++.dir/link.d
2024-11-20T16:22:36.4778166Z /usr/sbin/ld: cannot open dependency file CMakeFiles/cmModLib++.dir/link.d: no error
2024-11-20T16:22:36.4779121Z collect2: error: ld returned 1 exit status
2024-11-20T16:22:36.4783656Z [3/5] c++ -Imain.p -I. '-I../test cases/cmake/1 basic' -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -DMESON_MAGIC_FLAG=42 '-isystem../test cases/cmake/1 basic/subprojects/cmMod' -isystemsubprojects/cmMod '-isystem../test cases/cmake/1 basic/subprojects/cmMod/__CMake_build' -isystemsubprojects/cmMod/__CMake_build -MD -MQ main.p/main.cpp.o -MF main.p/main.cpp.o.d -o main.p/main.cpp.o -c '../test cases/cmake/1 basic/main.cpp'
2024-11-20T16:22:36.4787314Z ninja: build stopped: subcommand failed.

but the Fedora and Ubuntu ones should be easy.

@bonzini bonzini requested a review from jpakkane as a code owner November 20, 2024 18:09
@eli-schwartz
Copy link
Member

I have no idea about the Arch failure:

That is #13888

@bonzini
Copy link
Collaborator Author

bonzini commented Nov 20, 2024

Are the os_comp.yml Ubuntu Rolling tests failing because they use the old image? The image builder check itself is passing. :/

Sorry - I might be extremely confused, but I don't understand how to verify this myself.

@eli-schwartz
Copy link
Member

That is correct. We can therefore ignore those particular failures (which I think is 100% of the failures).

@bonzini
Copy link
Collaborator Author

bonzini commented Nov 20, 2024

Yes, the failing tests are CI Image builder/arch and linux/Ubuntu Rolling/*

@bonzini
Copy link
Collaborator Author

bonzini commented Dec 6, 2024

Ping.

@eli-schwartz eli-schwartz merged commit f9f69d8 into mesonbuild:master Dec 6, 2024
31 of 37 checks passed
@eli-schwartz
Copy link
Member

Apologies for forgetting about this.

@eli-schwartz
Copy link
Member

I have no idea about the Arch failure:

That is #13888

It appears to now be fixed on the cmake side: https://gitlab.kitware.com/cmake/cmake/-/issues/26498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants