Try #2: De-dup rpath arguments on apple clang #13963
Conversation
This was already done for dedup2_prefixes, also do it for dedup1_prefixes, and move export-dynamic to dedup1_args, where it belongs. Also modify some comments around this to clearly distinguish standalone argument matching and argument-prefix matching.
When followed by a comma, we can be absolutely sure that these are argument prefixes, and will not consume the next argument to form a single argument. Fixes spammy warnings on apple clang: `ld: warning: duplicate -rpath 'build/dist/darwin_universal/arm64/lib/pkgconfig/../../lib' ignored` Continuation from mesonbuild#13819
|
Basically, this is a more restricted version of the previous PR, and will only de-dup when:
In these cases it is not supposed to (and will not) slurp the next argument. I looked into adding more advanced de-dup that looks at the next argument, but it made argument construction very slow. |
Yeah that makes sense I guess. Disappointing but hopefully most people are using the version with |
|
We can probably make it happen if we rewrite CompilerArgs in C. |
|
I'm not necessarily opposed but it would have to be 100% optional to avoid breaking the use case of running meson directly from the git repository... that might make it less of an interesting change to make. :) |
Continuation of #13819.
CC: @eli-schwartz