tests: Avoid modifying '17 prebuild shared' test dir #13991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests can tread on each other's toes when parallelism is high enough.
In this case,
test_prebuilt_shared_lib
creates an object file in the17 prebuilt shared
test dir.test_prebuilt_shared_lib_rpath_same_prefix
usesshutil.copytree
to copy that same test dir to a temporary location.If the former test cleans up its object file while
copytree
is running, the copy can fail with a fatal ENOENTshutil.Error
.Use
copy_srcdir
to prevent this from happening.