Add start-group/end-group flags when linking a program with rustc #14026
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from .. import options | ||
| from ..linkers.linkers import GnuLikeDynamicLinkerMixin, SolarisDynamicLinker, CompCertDynamicLinker |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from .. import options | ||
| from ..linkers.linkers import GnuLikeDynamicLinkerMixin, SolarisDynamicLinker, CompCertDynamicLinker |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
| from .. import options | ||
| from ..linkers.linkers import GnuLikeDynamicLinkerMixin, SolarisDynamicLinker, CompCertDynamicLinker |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
bonzini
force-pushed
the
rust-group-libraries
branch
from
1167d7c to
37d1945
Compare
| from ..mesonlib import EnvironmentException, MesonException, Popen_safe_logged | ||
| from ..options import OptionKey | ||
| from .compilers import Compiler, clike_debug_args | ||
| from .mixins.clike import GROUP_FLAGS |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
bonzini
force-pushed
the
rust-group-libraries
branch
2 times, most recently
from
4d524dd to
502317e
Compare
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rust-group-libraries
branch
from
502317e to
ad18530
Compare
| @@ -62,6 +65,37 @@ | |||
| except StopIteration: | |||
| return None | |||
|
|
|||
|
|
|||
| class RustcCompilerArgs(arglist.CompilerArgs): | |||
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
This is needed for QEMU, but it may be useful anyway. Because rustc does not support extract_objects, QEMU creates a static library with all the C objects. It then passes this static library as
link_whole, together with another static library containing general purpose utility functions which is passed aslink_with.Unfortunately, these two have a circular dependency and they cannot be merged because of the
link_whole/link_withdifference. While lld seems to have the --start-group/--end-group semantics automatically, ld.bfd can fail if these options are needed. This can cause difference between distros depending on how Rust is packaged (e.g. Ubuntu 22.04 and Debian bookworm seem to use ld.bfd).To improve compatibility, add --start-group and --end-group options like Meson already does with C programs.
This is an alternative to #14031. It is a bit inferior for QEMU, but the changes are a bit simpler. Both can be included if desired.