Cleanup some issues (mostly typing) in dependency code #14034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because in at least one case it will lack the `log_tried` method.
For whatever reason Meson has always used None == <C Language>. This doesn't make a lot of sense to me, but it's how things currently work, and netcdf should handle that correctly.
It's possible to get an array of versions here, so we need to handle that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first bit of code split out of #13995
This contains generic cleanups to core dependency code (and to the python module around dependencies).
Theoretically, all of this could be tagged for backport, except maybe for the commit to make the assertions print a more helpful message.