Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run0 as a way to raise privileges #14037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rusty-snake
Copy link
Contributor

No description provided.

Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you can override this easily anyways, I wonder how important this is... at any rate, there's a major issue in the implementation no matter what.

@@ -115,7 +115,7 @@ running `sudo meson install` will drop permissions and rebuild out of date
targets as the original user, not as root.

*(since 1.1.0)* Re-invoking as root will try to guess the user's preferred method for
re-running commands as root. The order of precedence is: sudo, doas, pkexec
re-running commands as root. The order of precedence is: run0, sudo, doas, pkexec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider it unacceptable to change the order to stop using sudo as the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the ordering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per standard operating procedure, please change the ordering using git commit --amend && git push --force to commit the results, not a second commit. :)

@rusty-snake rusty-snake force-pushed the raise-privileges-with-run0 branch from 5fd9074 to 4481646 Compare December 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants