compiler,rust: No native-static-libs for wasm after 1.84 #14060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.84 uses the latest emsdk 3.1.68 [1], and it fixed an issue with Emscripten dynamic linking and libc [2]. After that no native-static-libs in the output if running: ``` rustc --target=wasm32-unknown-emscripten --crate-type staticlib --print native-static-libs - < /dev/null ``` [1] rust-lang/rust#131533 [2] rust-lang/libc#4002
| @@ -161,6 +161,9 @@ def _native_static_libs(self, work_dir: str, source_name: str) -> None: | |||
| # no match and kernel == none (i.e. baremetal) is a valid use case. | |||
| # return and let native_static_libs list empty | |||
| return | |||
| if self.info.system == 'emscripten': | |||
| # no match and emscripten is valid after rustc 1.84 | |||
| return | |||
There was a problem hiding this comment.
If it's expected to always not match, should we skip running rustc --crate-type staticlib --print ....... entirely, and simply return early from the function depending on self.version comparison?
There was a problem hiding this comment.
I mimicked the baremetal flow where not early-return. I understood that running "rustc" was interesting to check it the compiler can compile staticlib.
However, the decision is yours. Please let me know your preference, and I would be happy to assist with the early return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on adding support to gst-plugins-rs to
gst.wasm.gst.wasmis a GStreamer port to WebAssembly where meson works correctly for all C/C++ projects. The last release of Rust, version 1.84, unblocks an issue with that language. Rust 1.84 uses the latest emsdk 3.1.68. Among many other things, it fixed an issue with Emscripten dynamic linking and libc. After that, nonative-static-libsin the output if running:Note: