modules/gnome, modules/Python: Allow injecting RPATH flags through LDFLAGS if needed #14238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyspark
force-pushed
the
fix-rpath-passing-giscanner-macos
branch
from
bd23d47 to
d6d8b18
Compare
|
Would be great to have a test. You could modify |
|
Added a test for the former (it's a bit noisy, as I needed to add MSVC compatibility; let me know if that's needed or if it can be removed). For the changes re: RPATH, darwintests.py is not effective for this corner case; the flags need to pass through the GNOME module's filtering. The GNOME-less case is already covered in the |
eli-schwartz
requested changes
Feb 11, 2025
amyspark
force-pushed
the
fix-rpath-passing-giscanner-macos
branch
from
995bb68 to
5f8546d
Compare
amyspark
force-pushed
the
fix-rpath-passing-giscanner-macos
branch
3 times, most recently
from
3783881 to
24f948c
Compare
nirbheek
reviewed
Feb 17, 2025
…FLAGS if needed Fixes communicating the RPATH to g-i-scanner in macOS. See mesonbuild#14169
amyspark
force-pushed
the
fix-rpath-passing-giscanner-macos
branch
from
24f948c to
882dab2
Compare
nirbheek
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes communicating the RPATH to g-i-scanner in macOS.
See #14169
cc @nirbheek