Add cache to OptionKey #14250
Open
Add cache to OptionKey #14250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
cached-optionkey
branch
3 times, most recently
from
f52d09e to
9fdbd2b
Compare
15 tasks
bruchar1
force-pushed
the
cached-optionkey
branch
from
9fdbd2b to
ea79fd5
Compare
|
Do you even need to override equality if there's a cache? Wouldn't all equal objects be the same object (i.e. "a == b" becomes the same as "a is b")? |
OptionKey objects are used extensively. We want them with a simple API, but they also need to be optimized to not compromise meson performances. Since this is an immutable object, it is possible to cache the OptionKey object creation. We need to do it using the __new__ to make the caching mechanism transparent. Fixes mesonbuild#14245
bruchar1
force-pushed
the
cached-optionkey
branch
from
ea79fd5 to
7ee66f2
Compare
That's a good point. However, I don't see any hit on comparison operators in my profile. Therefore, I suppose Python already recognize the identity of objects when performing hash map lookup. |
bruchar1
force-pushed
the
cached-optionkey
branch
2 times, most recently
from
a4ade37 to
a4fab0f
Compare
|
With those optimisations, target generation is now even faster that before the merge of the options refactor (before options refactor: 73s, after options refactor: 77s, with those optimisations: 64s) |
This removes a few comparisons, and one function call.
It makes object initialisation slower...
bruchar1
force-pushed
the
cached-optionkey
branch
from
a4fab0f to
c06f203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionKey objects are used extensively. We want them with a simple API, but they also need to be optimized to not compromise meson performances.
Since this is an immutable object, it is possible to cache the OptionKey object creation. We need to do it using the new to make the caching mechanism transparent.
Fixes #14245