modules/gnome: Allow to specify the doc-format argument #14283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, the support for this argument is added since https://gitlab.gnome.org/GNOME/gobject-introspection/-/commit/9544cd6c962fab2c3203898779948309833e2439 |
mesonbuild/modules/gnome.py
Outdated
Comment on lines
1213
to
1214
| if kwargs['doc_format'] and self._gir_has_option('--doc-format'): | ||
| scan_command += ['--doc-format', kwargs['doc_format']] |
There was a problem hiding this comment.
When checking if it has been set, it should "probably" be is not None because someone could do
gnome.generate_gir(
...,
doc_format: '',
)and it's not clear what should happen then ignoring an explicitly specified value even if "'weird", feels strange to me.
There was a problem hiding this comment.
Added the is not None check,
The value is just a hint that get inserted into the generated .gir file so it is safe to be ignored if the scanner doesn't support it
Add the support for the doc-format argument if g-ir-scanner supports it. Ignore the argument otherwise as this is a no-op in such cases.
tintou
force-pushed
the
tintou/gir-doc-format
branch
from
58e6e66 to
5e00f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support for the doc-format argument if g-ir-scanner supports it.
Ignore the argument otherwise as this is a no-op in such cases.