rust: let doctests pick objects from dependencies #14973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 8, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 11, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 12, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Zhao Liu <[email protected]> Message-Id: <[email protected]>
bonzini
force-pushed
the
rust-doctest-objects
branch
from
206cac8 to
9e06656
Compare
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 13, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 13, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]>
patchew-importer
pushed a commit
to patchew-project/qemu
that referenced
this pull request
Sep 16, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]>
dcbaker
requested changes
Sep 16, 2025
There was a problem hiding this comment.
This looks correct to me, just one small nit.
@eli-schwartz asked whether this was a bug fix or a feature new... it's a good question. I think this works correctly for rust targets that are not doctests? If that's the case then I'd consider this a bug fix, if this doesn't work at all it's probably a new feature.
bonzini
force-pushed
the
rust-doctest-objects
branch
from
9e06656 to
e82f314
Compare
|
backends.py has an interesting idiom for keeping the unique elements of a list. This is much faster than OrderedSet: * dict.fromkeys() vs. OrderedSet.__init__(): 35% faster on Python 3.13, 50-60% faster on Python 3.10 * list(d) (d is a dict) vs. list(os) (os is an OrderedSet): up to 25% faster on Python 3.13, up to 15% faster on Python 3.10 though it tapers out after a few hundred elements. Add a function to mesonlib to encapsulate this idiom. Signed-off-by: Paolo Bonzini <[email protected]>
If a depedency includes object files, they have to be added to the doctest. However, NinjaBackend was not running flatten_object_list on the doctest. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
rust-doctest-objects
branch
from
e82f314 to
d8633f6
Compare
|
Then for posterity, I would consider this a bug fix rather than a new feature. |
stsquad
pushed a commit
to qemu/qemu
that referenced
this pull request
Sep 17, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]>
stsquad
pushed a commit
to qemu/qemu
that referenced
this pull request
Sep 18, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]>
abaire
pushed a commit
to abaire/xemu
that referenced
this pull request
Sep 19, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]> xemu: Update minimum Meson requirement to 1.8.4 to facilitate building on macOS with Clang 17. Fixes xemu-project#2442
mborgerson
pushed a commit
to xemu-project/xemu
that referenced
this pull request
Sep 19, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]> xemu: Update minimum Meson requirement to 1.8.4 to facilitate building on macOS with Clang 17. Fixes #2442
pbo-linaro
pushed a commit
to pbo-linaro/qemu-ci
that referenced
this pull request
Sep 22, 2025
Meson 1.9.0 provides mixed linking of Rust and C objects. As a side effect, this also allows adding dependencies with "sources: ..." files to Rust crates that use structured_sources(). It can also clean up up the meson.build files for Rust noticeably, but due to an issue with doctests (see mesonbuild/meson#14973) that will have to wait for 1.9.1. Reviewed-by: Zhao Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Bonzini <[email protected]>
dcbaker
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dependency includes object files, they have to be added to the doctest. However, NinjaBackend was not running flatten_object_list on the doctest.