Add all Swift-MesonLSP configs to package.json #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
reviewed
Oct 27, 2023
Allows improved visibility of these options, diagnostics, docs and auto-completion.
|
Is this good to go? |
|
If you say, that this is understandable for every person, even if they don't know the inner workings, then yes |
|
Yes it seems good enough. Things can always change later if you rename things or whatever :) |
|
Ok, then let's go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows improved visibility of these options, diagnostics, docs and auto-completion.
Draft, as I'm not sure whether these descriptions make sense for people that don't know about the language server/don't know the exact details