Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: fix symlink handling in mesonRootDirs #209

Merged
merged 1 commit into from
Nov 29, 2023
Merged

utils: fix symlink handling in mesonRootDirs #209

merged 1 commit into from
Nov 29, 2023

Conversation

andrei8l
Copy link
Contributor

@andrei8l andrei8l commented Nov 29, 2023

Bitwise check for File or Directory type to properly handle symlinks of both

Testing:

  • symlinked root meson.build gets picked up automatically
  • symlinked directory with meson.build appears in the Select configuration to use prompt if there's no root meson.build
  • regular files and directories still work
  • (symlinked) directory named meson.build doesn't get picked up as root configuration

Based on this sample.

@andrei8l andrei8l marked this pull request as draft November 29, 2023 08:16
@andrei8l andrei8l marked this pull request as ready for review November 29, 2023 08:21
@tristan957
Copy link
Contributor

Looks like Prettier is failing for the PR. Can you check on that?

@tristan957
Copy link
Contributor

Thanks for investigating!

@tristan957 tristan957 merged commit a55e5ed into mesonbuild:main Nov 29, 2023
5 checks passed
@andrei8l
Copy link
Contributor Author

Thanks for merging.

@andrei8l andrei8l deleted the mesonRootDirs-symlinks branch November 29, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants