Add libsass 3.6.4 #1153
Merged
Add libsass 3.6.4 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a direct copy of https://github.com/lazka/libsass/tree/meson which I've created for gtk back in the days. There is an open PR for adding meson support upstream in sass/libsass#3073 but the project is considered deprecated and hasn't seen a commit in over a year, so there is not much hope for progress there. There is a newer 3.6.5 release out, but I wanted to copy things as is from my fork first and look at updating it later.
tristan957
approved these changes
Sep 11, 2023
gtk3, which depends on this still works with 0.60, so allow older meson here too
and don't define ADD_EXPORTS then
With newer meson this is no longer needed: mesonbuild/meson#10339
It's always used on non-Windows, and not used on Windows, so make it required with the newer dependency() feature on non-Windows, and a no-op on Windows.
it's only used there
to match upstream
tristan957
reviewed
Sep 12, 2023
for the dummy dependency case
|
Thanks! |
lazka
added a commit
to lazka/wrapdb
that referenced
this pull request
Sep 18, 2023
This is a direct copy of https://github.com/lazka/sassc/tree/meson which I've created for gtk back in the days. This project is in a similar situation as mesonbuild#1153. There exists an upstream PR for adding meson (sass/sassc#269), but the project is unmaintained, so unlikely to see progress there.
Merged
jpakkane
pushed a commit
that referenced
this pull request
Sep 19, 2023
This is a direct copy of https://github.com/lazka/sassc/tree/meson which I've created for gtk back in the days. This project is in a similar situation as #1153. There exists an upstream PR for adding meson (sass/sassc#269), but the project is unmaintained, so unlikely to see progress there.
gnomesysadmins
pushed a commit
to GNOME/gtk
that referenced
this pull request
Sep 19, 2023
They were pointing to my personal fork, but I've now added them to wrapdb: * mesonbuild/wrapdb#1153 * mesonbuild/wrapdb#1185
fennewald
pushed a commit
to fennewald/wrapdb
that referenced
this pull request
Sep 29, 2023
This is a direct copy of https://github.com/lazka/sassc/tree/meson which I've created for gtk back in the days. This project is in a similar situation as mesonbuild#1153. There exists an upstream PR for adding meson (sass/sassc#269), but the project is unmaintained, so unlikely to see progress there.
willwray
pushed a commit
to willwray/wrapdb
that referenced
this pull request
Apr 22, 2024
This is a direct copy of https://github.com/lazka/sassc/tree/meson which I've created for gtk back in the days. This project is in a similar situation as mesonbuild#1153. There exists an upstream PR for adding meson (sass/sassc#269), but the project is unmaintained, so unlikely to see progress there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct copy of https://github.com/lazka/libsass/tree/meson which I've created for gtk back in the days.
There is an open PR for adding meson support upstream in sass/libsass#3073 but the project is considered deprecated and hasn't seen a commit in over a year, so there is not much hope for progress there.
There is a newer 3.6.5 release out, but I wanted to copy things as is from my fork first and look at updating it later.