argtable3: add initial wrap version #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovazquezblanco
force-pushed
the
argtable3
branch
from
71ceea0 to
1c9312f
Compare
|
Sorry, first PR here... I am guessing the errors come from the warning: This due to meson fatal warnings being enabled. Can I get a pointer on how I may be able to fix the warning? |
|
IMO these warnings should only be enabled for wraps that have custom meson.build files in this repository. |
|
@neheb, should I try to provide direct Meson support instead of relaying on a CMake build? Any other thing I can do to get this merged? Thanks |
antoniovazquezblanco
force-pushed
the
argtable3
branch
from
1c9312f to
fccbda4
Compare
|
ping @eli-schwartz |
antoniovazquezblanco
force-pushed
the
argtable3
branch
5 times, most recently
from
cca07f3 to
7787024
Compare
|
Finally found some time to get back into this. Wrote basic meson build file. Is it better now? Thanks |
antoniovazquezblanco
force-pushed
the
argtable3
branch
from
7787024 to
701d114
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.