abseil-cpp: remove gentables binary from static lib #1382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current meson patch for abseil-cpp includes
gaussian_distribution_gentables.cc
as a source file for the abseil_random static library.wrapdb/subprojects/packagefiles/abseil-cpp/meson.build
Lines 343 to 349 in f3628e2
gaussian_distribution_gentables.cc has its own
main()
function, and is meant to be compiled into a separate binary used to codegengaussian_distribution.cc
, as indicated here.gaussian_distribution.cc
is already committed to the abseil repo, so it does not need to be generated at build time.Currently, if you use this wrap and statically link abseil_random from an executable, you will run into an issue where multiple
main()
functions are defined due to the inclusion ofgaussian_distribution_gentables.cc
.This change removes
gaussian_distribution_gentables.cc
from the list of sources for abseil_random, resolving the issue.