Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-plane-sdk: new wrap #1394

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

judemille
Copy link
Contributor

@judemille judemille commented Feb 6, 2024

Packaging up the X-Plane plugin SDK for easy use with Meson.

@judemille judemille changed the title Add wrap: x-plane-sdk x-plane-sdk: new wrap Feb 6, 2024
@judemille judemille force-pushed the add-xplane-sdk branch 2 times, most recently from b0f96d4 to e3b08cc Compare February 6, 2024 00:55
@judemille
Copy link
Contributor Author

judemille commented Feb 6, 2024

Sanity checks pass on Arch Linux.

@@ -0,0 +1,121 @@
project(
'x-plane-sdk', 'c', 'cpp',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick glance I didn't see a C compiler being used for anything (other than library lookups that could be done with a C++ compiler just as easily). Do we need both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library, except for the C++ wrappers, is exposed as C. Am I mistaken to mark it as having C, in that case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those parts appear to be precompiled SDK binaries?

You don't need a C compiler to link to C libraries, only to compile them. In theory, someone that has a C++ compiler installed but doesn't have a C compiler (what does that mean, exactly??? who knows) could link to precompiled libraries in their C++ only software.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the build script -- a couple fixes, as well as making building the C++ wrappers optional, since not all may use them (instead using PPL if they still use C++).

This way, only people who really want the included wrappers get them, and it only asks for a C++ compiler if using them. Granted, the only platforms X-Plane supports all have C++ compilers, so I would be concerned if one managed to end up without one, but I suppose for minimal installs on Linux?

@judemille judemille force-pushed the add-xplane-sdk branch 3 times, most recently from 4f2bc5e to 4a27f42 Compare February 6, 2024 05:33
@judemille
Copy link
Contributor Author

oops, UI didn't update the CI status until after i clicked the re-request review button. fantastic UI design lmao.
lemme fix that

@judemille judemille force-pushed the add-xplane-sdk branch 2 times, most recently from a4a3a7f to 7bddd99 Compare February 7, 2024 00:40
@eli-schwartz
Copy link
Member

oops, UI didn't update the CI status until after i clicked the re-request review button. fantastic UI design lmao. lemme fix that

The brave new world of JavaScript... everything is dynamic up until you actually want it to be. :D

Started the CI

@judemille
Copy link
Contributor Author

I swear I thought I checked the meson_version to get it to the minimum with the necessary features before pushing. I guess I didn't do it right.

@judemille
Copy link
Contributor Author

I forgor to enable the C++ wrappers when testing that.

@judemille
Copy link
Contributor Author

@eli-schwartz Is this good to go now?

@judemille judemille force-pushed the add-xplane-sdk branch 2 times, most recently from 078b0f1 to 6ce6e86 Compare February 9, 2024 05:23
@judemille
Copy link
Contributor Author

judemille commented Feb 9, 2024

ok am i dumb or something? i can't work out why this build is failing

E: oh, it's because i read the docs wrong and flipped the bool values in my head

@jpakkane jpakkane merged commit a611271 into mesonbuild:master Mar 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants