-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-plane-sdk: new wrap #1394
x-plane-sdk: new wrap #1394
Conversation
b0f96d4
to
e3b08cc
Compare
Sanity checks pass on Arch Linux. |
@@ -0,0 +1,121 @@ | |||
project( | |||
'x-plane-sdk', 'c', 'cpp', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick glance I didn't see a C compiler being used for anything (other than library lookups that could be done with a C++ compiler just as easily). Do we need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library, except for the C++ wrappers, is exposed as C. Am I mistaken to mark it as having C, in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those parts appear to be precompiled SDK binaries?
You don't need a C compiler to link to C libraries, only to compile them. In theory, someone that has a C++ compiler installed but doesn't have a C compiler (what does that mean, exactly??? who knows) could link to precompiled libraries in their C++ only software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the build script -- a couple fixes, as well as making building the C++ wrappers optional, since not all may use them (instead using PPL if they still use C++).
This way, only people who really want the included wrappers get them, and it only asks for a C++ compiler if using them. Granted, the only platforms X-Plane supports all have C++ compilers, so I would be concerned if one managed to end up without one, but I suppose for minimal installs on Linux?
4f2bc5e
to
4a27f42
Compare
oops, UI didn't update the CI status until after i clicked the re-request review button. fantastic UI design lmao. |
a4a3a7f
to
7bddd99
Compare
The brave new world of JavaScript... everything is dynamic up until you actually want it to be. :D Started the CI |
I swear I thought I checked the |
7bddd99
to
9e5e715
Compare
I forgor to enable the C++ wrappers when testing that. |
9e5e715
to
2848e2b
Compare
@eli-schwartz Is this good to go now? |
078b0f1
to
6ce6e86
Compare
ok am i dumb or something? i can't work out why this build is failing E: oh, it's because i read the docs wrong and flipped the bool values in my head |
Signed-off-by: Julia DeMille <[email protected]>
6ce6e86
to
9968628
Compare
Packaging up the X-Plane plugin SDK for easy use with Meson.