abseil-cpp: Expose more missing headers #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enough for webrtc-audio-processing-2 to compile.
|
Thanks for the quick merge on the last one -- I missed a few and now tested this a bit better for the package this is being used in. |
|
know anything about that ppc failure? |
Looking at this line, it seems abseil only supports PPC with glibc and not musl, at least for now. |
|
If we want to, we could set |
|
Sure. I highly doubt anyone uses WrapDB on PPC anyway. |
ford-prefect
force-pushed
the
absl-more-missing-headers
branch
from
0339d26 to
171a7c2
Compare
|
Phew, looks like that got it to green. |
dcbaker
reviewed
Jan 10, 2025
| hw_cpp_flags = [] | ||
| if host_machine.cpu_family() == 'x86_64' | ||
| hw_cpp_flags += ['-maes', '-msse4.1'] | ||
| elif host_machine.cpu_family() == 'aarch64' and cpp.sizeof('void*') == 8 | ||
| hw_cpp_flags += ['-march=armv8-a+crypto'] | ||
| elif host_machine.cpu_family() == 'arm' and cpp.sizeof('void*') == 4 | ||
| hw_cpp_flags += ['-mfpu=neon'] | ||
| elif host_machine.cpu_family() == 'ppc' or host_machine.cpu_family() == 'ppc64' |
There was a problem hiding this comment.
elif host_machine.cpu_family().startswith('ppc') or elif host_machine.cpu_family() in ['ppc', 'ppc64']
For future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enough for webrtc-audio-processing-2 to compile.