avoid early return in saving histogram

mesoscope · Jun 10, 2024 · b1083ea · b1083ea
1 parent c16c377
commit b1083ea
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/cellpack/autopack/Analysis.py b/cellpack/autopack/Analysis.py
@@ -588,7 +588,23 @@ def run_analysis_workflow(
                 **analysis_config["create_report"],
             )
 
-    def histogram(self, distances, filename, title_str="", x_label="", y_label="", save_png=True, add_to_result=True):
+    def histogram(
+        self,
+        distances,
+        filename,
+        title_str="",
+        x_label="",
+        y_label="",
+        add_to_result=True,
+        save_png=False,
+    ):
+        if add_to_result:
+            # add histogrm to result file and display on the web page
+            self.helper.plot_data.add_histogram(
+                title=f"{title_str}: {x_label}",
+                xaxis_title=x_label,
+                traces={y_label: numpy.array(distances)},
+            )
         if save_png:
             # use matplotlib to create histogram and save as png
             plt.clf()
@@ -620,14 +636,6 @@ def histogram(self, distances, filename, title_str="", x_label="", y_label="", s
             plt.savefig(filename)
             plt.close()
 
-        if add_to_result:
-            # add histogrm to result file and display on the web page
-            self.helper.plot_data.add_histogram(
-                title=f"{title_str}: {x_label}",
-                xaxis_title=x_label,
-                traces={y_label: numpy.array(distances)},
-            )
-
     def plot(self, rdf, radii, file_name):
         plt.clf()
         matplotlib.rc("font", size=14)