Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot pack firebase recipes due to missing "composition" key #245

Closed
mogres opened this issue May 8, 2024 · 1 comment · Fixed by #248
Closed

Cannot pack firebase recipes due to missing "composition" key #245

mogres opened this issue May 8, 2024 · 1 comment · Fixed by #248

Comments

@mogres
Copy link
Collaborator

mogres commented May 8, 2024

Description

On the main branch, packing a firebase recipe results in an error. Here are the steps I followed:

Local recipe works as expected

image

Recipe is available on firebase

image

Packing the recipe from firebase results in an error

image

Expected Behavior

The firebase recipe should run similar to the local recipe

@rugeli
Copy link
Collaborator

rugeli commented May 8, 2024

Thank you for reporting this bug! I accidentally deleted the line that calls the path validation function within load_file() in cellpack/autopack/__init__.py. I will make a one-line pr and add it back.

expected behaviors are in this merged pr #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants