Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call path validation when initiating the packing for remote recipes #248

Merged
merged 2 commits into from
May 16, 2024

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented May 8, 2024

Problem

What is the problem this work solves, including
closes #245

Solution

What I/we did to solve this problem
Added the function call back for remote packings.
Expected behaviors in merged pr #230

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@rugeli rugeli requested review from meganrm and mogres May 8, 2024 20:27
Copy link

github-actions bot commented May 8, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli
Copy link
Collaborator Author

rugeli commented May 8, 2024

Quickest way to get the remote recipe path is to copy and paste the field recipe_path within recipes collection.
Screenshot 2024-05-08 at 1 30 35 PM

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update!

I was able to run the one_sphere recipe after deleting and reuploading it. The previous version did not have the recipe_path field and I wasn't able to update it by reuploading since a recipe with the same name was already in the firestore. Maybe some validation to update the recipe if the format/saved fields have changed might be useful?

@rugeli
Copy link
Collaborator Author

rugeli commented May 9, 2024

Thanks for the quick update!

I was able to run the one_sphere recipe after deleting and reuploading it. The previous version did not have the recipe_path field and I wasn't able to update it by reuploading since a recipe with the same name was already in the firestore. Maybe some validation to update the recipe if the format/saved fields have changed might be useful?

The Firebase system is still in active development, and as we're refining it, we may need to delete old test recipes periodically until things stabilize. I agree that adding validation in the future to handle updates, especially when fields or formats are missing, will be useful! Thanks for testing the database!

@rugeli rugeli merged commit 843dfec into main May 16, 2024
7 checks passed
@rugeli rugeli deleted the fix/call-path-validation branch May 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pack firebase recipes due to missing "composition" key
3 participants