Feature/run inherited objects #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/run-inherited-objects
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
Closed
mogres
approved these changes
Oct 9, 2023
meganrm
approved these changes
Oct 12, 2023
rugeli
added a commit
that referenced
this pull request
Dec 18, 2023
* [wip] prep recipe data for packing * get creds from local file * save firebase creds to a .creds file * remove cred arg * check for already handled values in remote recipes * can pack one sphere * * adding username to .creds * formatting * move `write_username_to_creds` * download recipe testing * edit comment * code refactor * lint * format tests * add prep_db_doc * changed class name in DBRecipeHandler * fix lint and test errors * initialize firebase handler only once * refactor message * add remote db options in `pack` * remove a print statement * rename and reorg DB handler * fix tests * move database_ids enum to interface_objects * remove db_handler in pack and recipe_loader * send db_handler in to autopack * rename functions * integrate DATABASE_NAMES into interface_objects * lint * Feature/run inherited objects (#198) * turn off resolving inheritance while uploading * able to upload recipes having "inherit" key * get download and pack to work, refactors needed * refactors * formatting * testing and refactor * Feature/save metadata to firebase (#206) * refactor AWS and firebase handler * databases initiation handling * refactor * Update .gitignore Co-authored-by: Saurabh Mogre <[email protected]> * add file existence check * refactor is_nested_list method * revert write_json_file * formatting --------- Co-authored-by: meganrm <[email protected]> Co-authored-by: Saurabh Mogre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #171
Solution
What I/we did to solve this problem
resolve_inheritancewithin the_read()method ofrecipe_loader.pyinheritwill be retainedType of change
Please delete options that are not relevant.
Steps to Verify:
upload -r examples/recipes/v2/gradients.jsonpack -r firebase:recipes/gradients_v-defaultScreenshots (optional):
Show-n-tell images/animations here
Before - the inheritance key was resolved when receiving the full recipe data for uploading
After - the key
inheritis now retained and its value points to a referenceKeyfiles (delete if not relevant):
DBRecipeHandler.pyrecipe_loader.py