-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save gradient data as image #216
Changes from 12 commits
1c4491d
4d4c0d3
a8b41ea
874ec12
a99fc74
2499d2b
2ba45ca
ff59ea0
0a02fec
8525d0e
c29994f
74567ef
252ab02
4d277df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,9 @@ def pack(recipe, config_path=None, analysis_config_path=None): | |
recipe_version=recipe_data["version"], | ||
image_export_options=packing_config_data.get("image_export_options"), | ||
parallel=packing_config_data.get("parallel", False), | ||
save_gradient_data_as_image=packing_config_data.get( | ||
"save_gradient_data_as_image", False | ||
), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is starting to make me think we should just send the config into analysis instead of unpacking values here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created an issue #227 to track this |
||
) | ||
if analysis_config_path is not None: | ||
analyze.run_analysis_workflow( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"name": "test_gradient_data_image", | ||
"format": "simularium", | ||
"inner_grid_method": "trimesh", | ||
"live_packing": false, | ||
"ordered_packing": false, | ||
"out": "out/", | ||
"overwrite_place_method": true, | ||
"place_method": "spheresSST", | ||
"save_analyze_result": true, | ||
"show_grid_plot": true, | ||
"number_of_packings": 1, | ||
"spacing": 0.25, | ||
"use_periodicity": false, | ||
"show_sphere_trees": false, | ||
"load_from_grid_file": true, | ||
"save_converted_recipe": true, | ||
"image_export_options": { | ||
"hollow": false, | ||
"voxel_size": [1,1,1], | ||
"projection_axis": "z" | ||
}, | ||
"save_gradient_data_as_image": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since this is a new config setting it should also have a default setting in the config loader. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed the default entries from the config file and added the new setting to |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to trim down the parameters and make this function more flexible!