Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent duplicate uploads of single packings #223

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Jan 19, 2024

Problem

What is the problem this work solves, including
When "save_analyze_result" is set to True in the config file, a single packing recipe will be uploaded twice

What I/we did to solve this problem
In Analysis.py at L2490, we made an update to the doloop function to call save_as_simularium only when number_of_packings > 1

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. pack -r examples/recipes/v2/one_sphere.json -c examples/packing-configs/debug.json

@rugeli rugeli requested review from meganrm and mogres January 19, 2024 23:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ba5a46) 98.63% compared to head (e3e08ed) 98.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          18       18           
  Lines         511      511           
=======================================
  Hits          504      504           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 19, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rugeli rugeli merged commit e8c834e into main Jan 26, 2024
7 checks passed
@rugeli rugeli deleted the fix/duplicate-packing branch January 26, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants