fix: convert "type" Enums to strings in v1 recipe for firebase upload duplication check

[rugeli]

Problem

What is the problem this work solves, including
Found a bug: a v1 recipe could be uploaded to firebase more than once

This issue arises because, during the version migration process, the "type" attribute of an object is converted into an Enum, whereas it is stored as a string in firebase database. So our duplication checking logic always find a difference in data types.

difference:

{
  "type_changes": {
    "root['type']": {
      "old_type": "<class 'str'>",
      "new_type": "<enum 'INGREDIENT_TYPE'>",
      "old_value": "single_sphere",
      "new_value": "<INGREDIENT_TYPE.SINGLE_SPHERE: 'single_sphere'>"
    }
  }
}

Solution

What I/we did to solve this problem
I added a value check for enum in the existing method prep_data_for_db within DBRecipeHandler

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

1. in DBRecipeHandler.py, comment out the return in DBUploader > upload_recipe() to let deeper system checks into objects and compositions
2. run upload -r examples/recipes/v1/one_sphere.json to upload the recipe to your dev database
3. repeat the upload command to verify that the duplication check correctly identifies each object and composition, preventing duplicate uploads

[github-actions]

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name	Encapsulating radius	Average number packed
ext_A	25	236.0

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key	Pairwise distance distribution
ext_A

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72ecf15) 98.63% compared to head (e9661ff) 98.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          18       18           
  Lines         511      511           
=======================================
  Hits          504      504           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mogres]

Good catch! Apologies it took so long to review.