-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set staging as the default database for S3 metadata storage #234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 19 19
Lines 563 563
=======================================
Hits 556 556
Misses 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running into an error
An error occurred while storing the file out/one_sphere/jitter/results_one_sphere_default-run_1.0.0_seed_0.simularium to S3: Failed to initialize a certificate credential. Caused by: "None could not be converted to bytes"
while packing the one_sphere
recipe in the PR description.
I do have firebase credentials and they are being loaded:
2024-02-28 15:36:40,857 - botocore.credentials - INFO - credentials.py:1255 - load(): Found credentials in shared credentials file: ~/.aws/credentials
The loaded botocore credential is for S3, and the error you ran into is from the Google Auth library for Firebase. My guess is that it has something to do with the And I definitely see how the error messaging could be clearer and more helpful here. I’ll have another pr to explicitly refine error handling for aws and firebase. Thank you for testing and giving feedback! |
Oops, just noticed the loaded credentials were for aws and not Firebase. My apologies! Will follow up in DM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to run recipes locally and from firebase, and am also able to upload to the staging database. Thanks for the updates!
…ture/default-stag-for-S3
Problem
Merge #230 before this PR
What is the problem this work solves, including
closes #233 #229
Solution
What I/we did to solve this problem
default_db
parameter if provided and applicable.default_db
tostaging
instore_metadata()
within the simularium helper.Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify:
pack -r examples/recipes/v2/one_sphere.json -c examples/packing-configs/run.json
, it shouldn't prompt you to choose a databaseScreenshots (optional):
Show-n-tell images/animations here