Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved mdutils to analysis requirements #240

Merged
merged 1 commit into from
Apr 2, 2024
Merged

moved mdutils to analysis requirements #240

merged 1 commit into from
Apr 2, 2024

Conversation

meganrm
Copy link
Member

@meganrm meganrm commented Mar 20, 2024

Problem

the install failed because it needed mdutils

Solution

mdutils is only used in the analysis code so I moved the requirement there

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@meganrm meganrm requested a review from mogres March 20, 2024 17:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (e8c834e) to head (9b808a1).
Report is 16 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          18       18           
  Lines         511      511           
=======================================
  Hits          504      504           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 20, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like mdutils was the only missing dependency. Hopefully once we re-release to pip we can run an example packing

@meganrm meganrm merged commit 7af6304 into main Apr 2, 2024
7 checks passed
@meganrm meganrm deleted the fix/mdutils branch April 2, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants