-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache pip dependencies in github actions #250
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 19 19
Lines 563 563
=======================================
Hits 556 556
Misses 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to consider upgrading setup.py
to pyproject.toml
sometime down the line. Otherwise, lgtm!
Agreed! I think a good way to do this is by using PDM to manage dependencies and create a synced |
Problem
Closes #249
Solution
Added
cache: "pip"
to github action workflows that install cellpack dependenciesType of change
Steps to Verify:
Checking runtime for github actions, we get a speedup of a few minutes on MacOS and Windows tests
Screenshots:
Before (from PR #247)
After: