Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache pip dependencies in github actions #250

Merged
merged 18 commits into from
May 21, 2024
Merged

Conversation

mogres
Copy link
Collaborator

@mogres mogres commented May 9, 2024

Problem

Closes #249

Solution

Added cache: "pip" to github action workflows that install cellpack dependencies

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

Checking runtime for github actions, we get a speedup of a few minutes on MacOS and Windows tests

Screenshots:

Before (from PR #247)

image

After:

image

Copy link

github-actions bot commented May 9, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (6b8a814) to head (c91b8c2).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          19       19           
  Lines         563      563           
=======================================
  Hits          556      556           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogres mogres requested review from meganrm and rugeli May 13, 2024 20:59
Copy link
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider upgrading setup.py to pyproject.toml sometime down the line. Otherwise, lgtm!

@mogres
Copy link
Collaborator Author

mogres commented May 13, 2024

We might want to consider upgrading setup.py to pyproject.toml sometime down the line. Otherwise, lgtm!

Agreed!

I think a good way to do this is by using PDM to manage dependencies and create a synced pyproject.toml that is stable across operating systems.

@mogres mogres marked this pull request as ready for review May 15, 2024 18:07
@mogres mogres merged commit a00a56f into main May 21, 2024
7 checks passed
@mogres mogres deleted the feature/cache-github-actions branch May 21, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache python installation in github actions
4 participants