Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup aws workflow #308

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Fix/cleanup aws workflow #308

merged 5 commits into from
Jan 30, 2025

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Jan 27, 2025

Problem

What is the problem this work solves, including
closes #304

Solution

What I/we did to solve this problem

  • Replace the Install AWS CLI step with a script that installs CLI directly from AWS
  • Included the --update flag to handle the existing installations

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. This workflow should be triggered by closing a pull request
  2. I have tested this workflow on a testing branch, and AWS CLI was installed as expected

@rugeli rugeli requested review from meganrm and mogres January 27, 2025 19:50
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@mogres
Copy link
Collaborator

mogres commented Jan 28, 2025

Hi Ruge, the updates look good! However, it looks like AWS CLI is preinstalled on github hosted runners as seen here in the CLI tools section (more documentation here). Can we check on the test branch whether removing the setup step has any effect? If so I would recommend just getting rid of the install step and using the preconfigured version of AWS CLI.

@rugeli rugeli force-pushed the fix/cleanup-aws-workflow branch from 825cf0b to bbb3aa5 Compare January 28, 2025 17:54
@rugeli
Copy link
Collaborator Author

rugeli commented Jan 28, 2025

Hi Ruge, the updates look good! However, it looks like AWS CLI is preinstalled on github hosted runners as seen here in the CLI tools section (more documentation here). Can we check on the test branch whether removing the setup step has any effect? If so I would recommend just getting rid of the install step and using the preconfigured version of AWS CLI.

Good point! We can simply rely on the preinstalled version. I've removed the installation step and added a step to check the version instead. It worked fine. Thank you for catching that!

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the idea of not having to download packages through apt-get as that can be sometimes unreliable

@rugeli rugeli merged commit 34c0772 into main Jan 30, 2025
7 checks passed
@rugeli rugeli deleted the fix/cleanup-aws-workflow branch January 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix awscli installation in github actions
3 participants