-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cleanup aws workflow #308
Conversation
Hi Ruge, the updates look good! However, it looks like AWS CLI is preinstalled on github hosted runners as seen here in the CLI tools section (more documentation here). Can we check on the test branch whether removing the setup step has any effect? If so I would recommend just getting rid of the install step and using the preconfigured version of AWS CLI. |
825cf0b
to
bbb3aa5
Compare
Good point! We can simply rely on the preinstalled version. I've removed the installation step and added a step to check the version instead. It worked fine. Thank you for catching that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like the idea of not having to download packages through apt-get
as that can be sometimes unreliable
Problem
What is the problem this work solves, including
closes #304
Solution
What I/we did to solve this problem
Install AWS CLI
step with a script that installs CLI directly from AWS--update
flag to handle the existing installationsType of change
Please delete options that are not relevant.
Steps to Verify: