Skip to content

Commit

Permalink
fix(knative): delete webhook before upgrade (#1519)
Browse files Browse the repository at this point in the history
  • Loading branch information
mhrabovcin authored Oct 16, 2024
1 parent 640159b commit 3df4bf5
Show file tree
Hide file tree
Showing 3 changed files with 79 additions and 2 deletions.
2 changes: 1 addition & 1 deletion staging/knative/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: knative
version: 1.15.2
version: 1.15.3
description: "Kubernetes-based platform to build, deploy, and manage modern serverless workloads"
home: https://knative.dev/
maintainers:
Expand Down
77 changes: 77 additions & 0 deletions staging/knative/charts/serving/templates/pre-upgrade-hook.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
apiVersion: v1
kind: ServiceAccount
metadata:
name: "{{ .Release.Name }}-pre-upgrade"
namespace: knative-serving
annotations:
helm.sh/hook: pre-upgrade
helm.sh/hook-weight: "-5"
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: "{{ .Release.Name }}-{{ .Chart.Name }}-pre-upgrade"
annotations:
"helm.sh/hook": pre-upgrade
"helm.sh/hook-weight": "-5"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
rules:
- apiGroups: ["admissionregistration.k8s.io"]
resources: ["validatingwebhookconfigurations"]
verbs: ["get", "list", "delete"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: "{{ .Release.Name }}-{{ .Chart.Name }}-pre-upgrade"
annotations:
"helm.sh/hook": pre-upgrade
"helm.sh/hook-weight": "-4"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: "{{ .Release.Name }}-{{ .Chart.Name }}-pre-upgrade"
subjects:
- kind: ServiceAccount
name: "{{ .Release.Name }}-pre-upgrade"
namespace: knative-serving
---
apiVersion: batch/v1
kind: Job
metadata:
name: "{{ .Release.Name }}-pre-upgrade-webhook"
namespace: knative-serving
labels:
app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
app.kubernetes.io/instance: {{ .Release.Name | quote }}
app.kubernetes.io/version: {{ .Chart.AppVersion }}
helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
annotations:
"helm.sh/hook": pre-upgrade
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
spec:
template:
metadata:
name: "{{ .Release.Name }}"
labels:
app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
app.kubernetes.io/instance: {{ .Release.Name | quote }}
helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
annotations:
sidecar.istio.io/inject: "false"
spec:
restartPolicy: Never
serviceAccountName: "{{ .Release.Name }}-pre-upgrade"
{{- if .Values.global.priorityClassName }}
priorityClassName: "{{ .Values.global.priorityClassName }}"
{{- end }}
containers:
- name: pre-upgrade-job
image: "{{.Values.global.image}}:{{.Values.global.tag}}"
command:
- kubectl
- delete
- ValidatingWebhookConfiguration
- config.webhook.serving.knative.dev
2 changes: 1 addition & 1 deletion staging/knative/charts/serving/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
global:
serviceLabels: {}
image: docker.io/bitnami/kubectl
tag: 1.29.2
tag: 1.30.5

autoscaler:
containerConcurrencyTargetPercentage: "70"
Expand Down

0 comments on commit 3df4bf5

Please sign in to comment.